LCOV - differential code coverage report
Current view: top level - src/backend/access/brin - brin_validate.c (source / functions) Coverage Total Hit UBC CBC
Current: c70b6db34ffeab48beef1fb4ce61bcad3772b8dd vs 06473f5a344df8c9594ead90a609b86f6724cff8 Lines: 77.5 % 89 69 20 69
Current Date: 2025-09-06 07:49:51 +0900 Functions: 100.0 % 1 1 1
Baseline: lcov-20250906-005545-baseline Branches: 52.6 % 78 41 37 41
Baseline Date: 2025-09-05 08:21:35 +0100 Line coverage date bins:
Legend: Lines:     hit not hit
Branches: + taken - not taken # not executed
(30,360] days: 100.0 % 1 1 1
(360..) days: 77.3 % 88 68 20 68
Function coverage date bins:
(360..) days: 100.0 % 1 1 1
Branch coverage date bins:
(360..) days: 52.6 % 78 41 37 41

 Age         Owner                    Branch data    TLA  Line data    Source code
                                  1                 :                : /*-------------------------------------------------------------------------
                                  2                 :                :  *
                                  3                 :                :  * brin_validate.c
                                  4                 :                :  *    Opclass validator for BRIN.
                                  5                 :                :  *
                                  6                 :                :  * Portions Copyright (c) 1996-2025, PostgreSQL Global Development Group
                                  7                 :                :  * Portions Copyright (c) 1994, Regents of the University of California
                                  8                 :                :  *
                                  9                 :                :  * IDENTIFICATION
                                 10                 :                :  *    src/backend/access/brin/brin_validate.c
                                 11                 :                :  *
                                 12                 :                :  *-------------------------------------------------------------------------
                                 13                 :                :  */
                                 14                 :                : #include "postgres.h"
                                 15                 :                : 
                                 16                 :                : #include "access/amvalidate.h"
                                 17                 :                : #include "access/brin_internal.h"
                                 18                 :                : #include "access/htup_details.h"
                                 19                 :                : #include "catalog/pg_amop.h"
                                 20                 :                : #include "catalog/pg_amproc.h"
                                 21                 :                : #include "catalog/pg_opclass.h"
                                 22                 :                : #include "catalog/pg_type.h"
                                 23                 :                : #include "utils/builtins.h"
                                 24                 :                : #include "utils/lsyscache.h"
                                 25                 :                : #include "utils/regproc.h"
                                 26                 :                : #include "utils/syscache.h"
                                 27                 :                : 
                                 28                 :                : /*
                                 29                 :                :  * Validator for a BRIN opclass.
                                 30                 :                :  *
                                 31                 :                :  * Some of the checks done here cover the whole opfamily, and therefore are
                                 32                 :                :  * redundant when checking each opclass in a family.  But they don't run long
                                 33                 :                :  * enough to be much of a problem, so we accept the duplication rather than
                                 34                 :                :  * complicate the amvalidate API.
                                 35                 :                :  */
                                 36                 :                : bool
 3520 tgl@sss.pgh.pa.us          37                 :CBC         216 : brinvalidate(Oid opclassoid)
                                 38                 :                : {
 3516                            39                 :            216 :     bool        result = true;
                                 40                 :                :     HeapTuple   classtup;
                                 41                 :                :     Form_pg_opclass classform;
                                 42                 :                :     Oid         opfamilyoid;
                                 43                 :                :     Oid         opcintype;
                                 44                 :                :     char       *opclassname;
                                 45                 :                :     char       *opfamilyname;
                                 46                 :                :     CatCList   *proclist,
                                 47                 :                :                *oprlist;
                                 48                 :            216 :     uint64      allfuncs = 0;
                                 49                 :            216 :     uint64      allops = 0;
                                 50                 :                :     List       *grouplist;
                                 51                 :                :     OpFamilyOpFuncGroup *opclassgroup;
                                 52                 :                :     int         i;
                                 53                 :                :     ListCell   *lc;
                                 54                 :                : 
                                 55                 :                :     /* Fetch opclass information */
 3520                            56                 :            216 :     classtup = SearchSysCache1(CLAOID, ObjectIdGetDatum(opclassoid));
                                 57         [ -  + ]:            216 :     if (!HeapTupleIsValid(classtup))
 3520 tgl@sss.pgh.pa.us          58         [ #  # ]:UBC           0 :         elog(ERROR, "cache lookup failed for operator class %u", opclassoid);
 3520 tgl@sss.pgh.pa.us          59                 :CBC         216 :     classform = (Form_pg_opclass) GETSTRUCT(classtup);
                                 60                 :                : 
                                 61                 :            216 :     opfamilyoid = classform->opcfamily;
                                 62                 :            216 :     opcintype = classform->opcintype;
 3516                            63                 :            216 :     opclassname = NameStr(classform->opcname);
                                 64                 :                : 
                                 65                 :                :     /* Fetch opfamily information */
  225 peter@eisentraut.org       66                 :            216 :     opfamilyname = get_opfamily_name(opfamilyoid, false);
                                 67                 :                : 
                                 68                 :                :     /* Fetch all operators and support functions of the opfamily */
 3520 tgl@sss.pgh.pa.us          69                 :            216 :     oprlist = SearchSysCacheList1(AMOPSTRATEGY, ObjectIdGetDatum(opfamilyoid));
                                 70                 :            216 :     proclist = SearchSysCacheList1(AMPROCNUM, ObjectIdGetDatum(opfamilyoid));
                                 71                 :                : 
                                 72                 :                :     /* Check individual support functions */
                                 73         [ +  + ]:           2034 :     for (i = 0; i < proclist->n_members; i++)
                                 74                 :                :     {
                                 75                 :           1818 :         HeapTuple   proctup = &proclist->members[i]->tuple;
                                 76                 :           1818 :         Form_pg_amproc procform = (Form_pg_amproc) GETSTRUCT(proctup);
                                 77                 :                :         bool        ok;
                                 78                 :                : 
                                 79                 :                :         /* Check procedure numbers and function signatures */
 3516                            80   [ +  +  +  +  :           1818 :         switch (procform->amprocnum)
                                              +  + ]
                                 81                 :                :         {
                                 82                 :            342 :             case BRIN_PROCNUM_OPCINFO:
                                 83                 :            342 :                 ok = check_amproc_signature(procform->amproc, INTERNALOID, true,
                                 84                 :                :                                             1, 1, INTERNALOID);
                                 85                 :            342 :                 break;
                                 86                 :            342 :             case BRIN_PROCNUM_ADDVALUE:
                                 87                 :            342 :                 ok = check_amproc_signature(procform->amproc, BOOLOID, true,
                                 88                 :                :                                             4, 4, INTERNALOID, INTERNALOID,
                                 89                 :                :                                             INTERNALOID, INTERNALOID);
                                 90                 :            342 :                 break;
                                 91                 :            342 :             case BRIN_PROCNUM_CONSISTENT:
                                 92                 :            342 :                 ok = check_amproc_signature(procform->amproc, BOOLOID, true,
                                 93                 :                :                                             3, 4, INTERNALOID, INTERNALOID,
                                 94                 :                :                                             INTERNALOID, INT4OID);
                                 95                 :            342 :                 break;
                                 96                 :            342 :             case BRIN_PROCNUM_UNION:
                                 97                 :            342 :                 ok = check_amproc_signature(procform->amproc, BOOLOID, true,
                                 98                 :                :                                             3, 3, INTERNALOID, INTERNALOID,
                                 99                 :                :                                             INTERNALOID);
                                100                 :            342 :                 break;
 1986 akorotkov@postgresql      101                 :            213 :             case BRIN_PROCNUM_OPTIONS:
                                102                 :            213 :                 ok = check_amoptsproc_signature(procform->amproc);
                                103                 :            213 :                 break;
 3516 tgl@sss.pgh.pa.us         104                 :            237 :             default:
                                105                 :                :                 /* Complain if it's not a valid optional proc number */
                                106         [ +  - ]:            237 :                 if (procform->amprocnum < BRIN_FIRST_OPTIONAL_PROCNUM ||
                                107         [ -  + ]:            237 :                     procform->amprocnum > BRIN_LAST_OPTIONAL_PROCNUM)
                                108                 :                :                 {
 3516 tgl@sss.pgh.pa.us         109         [ #  # ]:UBC           0 :                     ereport(INFO,
                                110                 :                :                             (errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
                                111                 :                :                              errmsg("operator family \"%s\" of access method %s contains function %s with invalid support number %d",
                                112                 :                :                                     opfamilyname, "brin",
                                113                 :                :                                     format_procedure(procform->amproc),
                                114                 :                :                                     procform->amprocnum)));
                                115                 :              0 :                     result = false;
                                116                 :              0 :                     continue;   /* omit bad proc numbers from allfuncs */
                                117                 :                :                 }
                                118                 :                :                 /* Can't check signatures of optional procs, so assume OK */
 3516 tgl@sss.pgh.pa.us         119                 :CBC         237 :                 ok = true;
                                120                 :            237 :                 break;
                                121                 :                :         }
                                122                 :                : 
                                123         [ -  + ]:           1818 :         if (!ok)
                                124                 :                :         {
 3516 tgl@sss.pgh.pa.us         125         [ #  # ]:UBC           0 :             ereport(INFO,
                                126                 :                :                     (errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
                                127                 :                :                      errmsg("operator family \"%s\" of access method %s contains function %s with wrong signature for support number %d",
                                128                 :                :                             opfamilyname, "brin",
                                129                 :                :                             format_procedure(procform->amproc),
                                130                 :                :                             procform->amprocnum)));
                                131                 :              0 :             result = false;
                                132                 :                :         }
                                133                 :                : 
                                134                 :                :         /* Track all valid procedure numbers seen in opfamily */
 3516 tgl@sss.pgh.pa.us         135                 :CBC        1818 :         allfuncs |= ((uint64) 1) << procform->amprocnum;
                                136                 :                :     }
                                137                 :                : 
                                138                 :                :     /* Check individual operators */
 3520                           139         [ +  + ]:           2724 :     for (i = 0; i < oprlist->n_members; i++)
                                140                 :                :     {
                                141                 :           2508 :         HeapTuple   oprtup = &oprlist->members[i]->tuple;
                                142                 :           2508 :         Form_pg_amop oprform = (Form_pg_amop) GETSTRUCT(oprtup);
                                143                 :                : 
                                144                 :                :         /* Check that only allowed strategy numbers exist */
 3516                           145   [ +  -  -  + ]:           2508 :         if (oprform->amopstrategy < 1 || oprform->amopstrategy > 63)
                                146                 :                :         {
 3516 tgl@sss.pgh.pa.us         147         [ #  # ]:UBC           0 :             ereport(INFO,
                                148                 :                :                     (errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
                                149                 :                :                      errmsg("operator family \"%s\" of access method %s contains operator %s with invalid strategy number %d",
                                150                 :                :                             opfamilyname, "brin",
                                151                 :                :                             format_operator(oprform->amopopr),
                                152                 :                :                             oprform->amopstrategy)));
                                153                 :              0 :             result = false;
                                154                 :                :         }
                                155                 :                :         else
                                156                 :                :         {
                                157                 :                :             /*
                                158                 :                :              * The set of operators supplied varies across BRIN opfamilies.
                                159                 :                :              * Our plan is to identify all operator strategy numbers used in
                                160                 :                :              * the opfamily and then complain about datatype combinations that
                                161                 :                :              * are missing any operator(s).  However, consider only numbers
                                162                 :                :              * that appear in some non-cross-type case, since cross-type
                                163                 :                :              * operators may have unique strategies.  (This is not a great
                                164                 :                :              * heuristic, in particular an erroneous number used in a
                                165                 :                :              * cross-type operator will not get noticed; but the core BRIN
                                166                 :                :              * opfamilies are messy enough to make it necessary.)
                                167                 :                :              */
 3516 tgl@sss.pgh.pa.us         168         [ +  + ]:CBC        2508 :             if (oprform->amoplefttype == oprform->amoprighttype)
                                169                 :           1302 :                 allops |= ((uint64) 1) << oprform->amopstrategy;
                                170                 :                :         }
                                171                 :                : 
                                172                 :                :         /* brin doesn't support ORDER BY operators */
 3520                           173         [ +  - ]:           2508 :         if (oprform->amoppurpose != AMOP_SEARCH ||
                                174         [ -  + ]:           2508 :             OidIsValid(oprform->amopsortfamily))
                                175                 :                :         {
 3516 tgl@sss.pgh.pa.us         176         [ #  # ]:UBC           0 :             ereport(INFO,
                                177                 :                :                     (errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
                                178                 :                :                      errmsg("operator family \"%s\" of access method %s contains invalid ORDER BY specification for operator %s",
                                179                 :                :                             opfamilyname, "brin",
                                180                 :                :                             format_operator(oprform->amopopr))));
                                181                 :              0 :             result = false;
                                182                 :                :         }
                                183                 :                : 
                                184                 :                :         /* Check operator signature --- same for all brin strategies */
 3516 tgl@sss.pgh.pa.us         185         [ -  + ]:CBC        2508 :         if (!check_amop_signature(oprform->amopopr, BOOLOID,
                                186                 :                :                                   oprform->amoplefttype,
                                187                 :                :                                   oprform->amoprighttype))
                                188                 :                :         {
 3516 tgl@sss.pgh.pa.us         189         [ #  # ]:UBC           0 :             ereport(INFO,
                                190                 :                :                     (errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
                                191                 :                :                      errmsg("operator family \"%s\" of access method %s contains operator %s with wrong signature",
                                192                 :                :                             opfamilyname, "brin",
                                193                 :                :                             format_operator(oprform->amopopr))));
                                194                 :              0 :             result = false;
                                195                 :                :         }
                                196                 :                :     }
                                197                 :                : 
                                198                 :                :     /* Now check for inconsistent groups of operators/functions */
 3516 tgl@sss.pgh.pa.us         199                 :CBC         216 :     grouplist = identify_opfamily_groups(oprlist, proclist);
                                200                 :            216 :     opclassgroup = NULL;
                                201   [ +  -  +  +  :            804 :     foreach(lc, grouplist)
                                              +  + ]
                                202                 :                :     {
                                203                 :            588 :         OpFamilyOpFuncGroup *thisgroup = (OpFamilyOpFuncGroup *) lfirst(lc);
                                204                 :                : 
                                205                 :                :         /* Remember the group exactly matching the test opclass */
                                206         [ +  + ]:            588 :         if (thisgroup->lefttype == opcintype &&
                                207         [ +  + ]:            306 :             thisgroup->righttype == opcintype)
                                208                 :            216 :             opclassgroup = thisgroup;
                                209                 :                : 
                                210                 :                :         /*
                                211                 :                :          * Some BRIN opfamilies expect cross-type support functions to exist,
                                212                 :                :          * and some don't.  We don't know exactly which are which, so if we
                                213                 :                :          * find a cross-type operator for which there are no support functions
                                214                 :                :          * at all, let it pass.  (Don't expect that all operators exist for
                                215                 :                :          * such cross-type cases, either.)
                                216                 :                :          */
                                217         [ +  + ]:            588 :         if (thisgroup->functionset == 0 &&
                                218         [ +  - ]:            246 :             thisgroup->lefttype != thisgroup->righttype)
                                219                 :            246 :             continue;
                                220                 :                : 
                                221                 :                :         /*
                                222                 :                :          * Else complain if there seems to be an incomplete set of either
                                223                 :                :          * operators or support functions for this datatype pair.
                                224                 :                :          */
                                225         [ -  + ]:            342 :         if (thisgroup->operatorset != allops)
                                226                 :                :         {
 3516 tgl@sss.pgh.pa.us         227         [ #  # ]:UBC           0 :             ereport(INFO,
                                228                 :                :                     (errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
                                229                 :                :                      errmsg("operator family \"%s\" of access method %s is missing operator(s) for types %s and %s",
                                230                 :                :                             opfamilyname, "brin",
                                231                 :                :                             format_type_be(thisgroup->lefttype),
                                232                 :                :                             format_type_be(thisgroup->righttype))));
                                233                 :              0 :             result = false;
                                234                 :                :         }
 3516 tgl@sss.pgh.pa.us         235         [ -  + ]:CBC         342 :         if (thisgroup->functionset != allfuncs)
                                236                 :                :         {
 3516 tgl@sss.pgh.pa.us         237         [ #  # ]:UBC           0 :             ereport(INFO,
                                238                 :                :                     (errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
                                239                 :                :                      errmsg("operator family \"%s\" of access method %s is missing support function(s) for types %s and %s",
                                240                 :                :                             opfamilyname, "brin",
                                241                 :                :                             format_type_be(thisgroup->lefttype),
                                242                 :                :                             format_type_be(thisgroup->righttype))));
                                243                 :              0 :             result = false;
                                244                 :                :         }
                                245                 :                :     }
                                246                 :                : 
                                247                 :                :     /* Check that the originally-named opclass is complete */
 3516 tgl@sss.pgh.pa.us         248   [ +  -  -  + ]:CBC         216 :     if (!opclassgroup || opclassgroup->operatorset != allops)
                                249                 :                :     {
 3516 tgl@sss.pgh.pa.us         250         [ #  # ]:UBC           0 :         ereport(INFO,
                                251                 :                :                 (errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
                                252                 :                :                  errmsg("operator class \"%s\" of access method %s is missing operator(s)",
                                253                 :                :                         opclassname, "brin")));
                                254                 :              0 :         result = false;
                                255                 :                :     }
 3520 tgl@sss.pgh.pa.us         256         [ +  + ]:CBC        1080 :     for (i = 1; i <= BRIN_MANDATORY_NPROCS; i++)
                                257                 :                :     {
 3516                           258         [ +  - ]:            864 :         if (opclassgroup &&
                                259         [ +  - ]:            864 :             (opclassgroup->functionset & (((int64) 1) << i)) != 0)
 3520                           260                 :            864 :             continue;           /* got it */
 3516 tgl@sss.pgh.pa.us         261         [ #  # ]:UBC           0 :         ereport(INFO,
                                262                 :                :                 (errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
                                263                 :                :                  errmsg("operator class \"%s\" of access method %s is missing support function %d",
                                264                 :                :                         opclassname, "brin", i)));
                                265                 :              0 :         result = false;
                                266                 :                :     }
                                267                 :                : 
 3520 tgl@sss.pgh.pa.us         268                 :CBC         216 :     ReleaseCatCacheList(proclist);
                                269                 :            216 :     ReleaseCatCacheList(oprlist);
 3516                           270                 :            216 :     ReleaseSysCache(classtup);
                                271                 :                : 
                                272                 :            216 :     return result;
                                273                 :                : }
        

Generated by: LCOV version 2.4-beta